Skip to content

Conversation

@MathurAditya724
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Dec 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
spotlightjs Skipped Skipped Jan 6, 2026 2:43pm

@MathurAditya724 MathurAditya724 marked this pull request as ready for review December 31, 2025 14:32
@MathurAditya724 MathurAditya724 requested a review from BYK December 31, 2025 14:32
// Respect fullscreen state - hide drag bar if in fullscreen mode
if (window.__ELECTRON_IS_FULLSCREEN__) {
dragBar.style.display = 'none';
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fullscreen state lost on page reload

When the page reloads while in fullscreen mode, the window.__ELECTRON_IS_FULLSCREEN__ variable is lost since it's stored on the window object which is recreated. The did-finish-load handler creates the drag bar without checking current fullscreen state, and useElectronFullscreen initializes to false since the variable is undefined. The enter-full-screen event won't re-fire because the window is already fullscreen. This results in the UI showing non-fullscreen state (visible spacer and drag bar) until the user exits and re-enters fullscreen. The main process could inject the current state by calling win.isFullScreen() in the did-finish-load handler.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the refactoring and the look (based on the videos you shared, have not tested locally)

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@MathurAditya724 MathurAditya724 enabled auto-merge (squash) January 6, 2026 14:43
@MathurAditya724 MathurAditya724 merged commit d38bd55 into main Jan 6, 2026
20 checks passed
@MathurAditya724 MathurAditya724 deleted the adi/fix/fullscreen-css branch January 6, 2026 14:49
@github-actions github-actions bot mentioned this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants